Welcome, Guest
Username: Password: Remember me
Forgot your password? Forgot your username? Create an account
Forum
Debug
Closed tickets.
[FIXED] Numeric validation + fix
  • Page:
  • 1

TOPIC:

Numeric validation + fix 12 Dec 2012 11:29 #6028

Hello,

I found a minor issue with the numeric validation rule (using Cook 2.0). I have a required number field (int) in a table, for which 0 is an valid value. The JQuery validation works fine, but when the form rule is invoked from the server it generates an error when '0' is entered.

By looking at the code for the validation I spotted the issue. It is in in the /classes/rule.php class. When it does the required and empty check in the beginning of the testDefaults method it uses PHP's empty method to test if a value has been provided. However, this function considers values like 0, or 0.0, or '0' to be empty!

I fixed it as follows around line 96 in the testDefaults method:
		if ($required && empty($value))
		{
                    // valid when not numeric, or when it is a valid value
                    return (($element['validate']!="numeric")||(is_numeric($value)));
//			return false;
		}

Kind regards,

Misha
The following user(s) said Thank You: JoomGuy

Please Log in or Create an account to join the conversation.

Re: Numeric validation + fix 15 Dec 2012 14:22 #6112

  • admin
  • admin's Avatar
  • Offline
  • Administrator
  • Administrator
  • Chef
  • Posts: 3711
  • Thank you received: 986
You cannot write this code there, because testDefaults() is called by all rules, even not numeric.

I suggest you to write this in the numeric rule file.

Will check this...
Coding is now a piece of cake

Please Log in or Create an account to join the conversation.
  • Page:
  • 1
Forum
Debug
Closed tickets.
[FIXED] Numeric validation + fix
Time to create page: 0.078 seconds
“
”

For starters it's just so easy to design an app in a way that I'm used to i.e. database first then views followed by customization. The fork system is pure brilliance from a developer standpoint as I can override things and still add and update my projects with minimal effort! Truly amazing to be able to build components in Joomla using incremental refinement without having to do everything by hand. Thanks for the great tool! I am so much more productive now than ever and I can't imagine building components any other way!!!!
Dave (Forum)

Get Started

Log In Sign In